Product review · 4 September 2026

Jarvis voice and conversation pipeline

The ideas improve Jarvis. This implementation does not yet. It raises routing recall at the cost of routing trust, hides mobile outcomes, and adds avoidable latency and privacy exposure.

Verdict: changes requested before release. Keep conversation, barge-in, concise speech, and contextual notifications. Redesign project grounding around an explicit slot boundary, restore one owner for acknowledgements and presentation state, and make conversation one-call and project-independent.

Findings: 16 · actionable: 15

+599 −1325baf144b^..b83823baround 1

0/5

Needs redesign before release

Twelve P1 defects affect routing authority, canonical instructions, result visibility, privacy, and latency.

Walkthrough

The inclusive range covers commits 5baf144b and b83823ba. It adds direct conversational answers, semantic acknowledgements, descriptive push notifications, mobile barge-in and shorter speech, a match-first project grounder, and a denser mobile Task Desk presentation.

Conversation, shorter spoken completion, barge-in, and more informative notifications are good product goals.
Match-first grounding improves recall for novel phrasing and observed ASR variants, but removes the grammatical boundary that made routing safe.
Mobile now has three competing representations of outcome state: transient message, presentation buffer, and Task Desk cards; the new filter hides the only result-bearing one.
The range is type-correct and its 87 focused tests pass, yet direct negative probes reproduce routing and clarification failures absent from the suite.

Does it improve Jarvis?

Worth keeping

General questions no longer need a coding task.
Barge-in gives mobile users immediate control of speech.
Short completion speech respects voice as a summary channel.
Project/thread context makes notifications easier to identify when privacy allows.
Match-first scoring covers real ASR variants and trailing phrasing missed by narrow regexes.

Why the net result is negative today

Any task word can become a project target.
Confirmation can mutate the instruction.
Web bypasses confirmation.
Mobile hides outcomes and keeps stale blockers.
Conversation adds two model round trips and still requires a project.
Push enrichment adds privacy and database cost to the event path.

Better product shape

Ground in two stages: extract one project-bearing span from typed grammar or ASR metadata, then resolve only that span against a precompiled bounded catalog.
Keep one acknowledgement owner: an action-neutral local cue before the Host responds; contextual speech only from the validated accepted result.
Use one outcome projection: newest event per task/turn, where terminal events supersede blockers and Task Desk cards never stand in for result text.
Make converse a separate request kind: no project required, one supervisor call, typed failure, explicit retry semantics.
Keep notifications generic by default: classify before database reads; descriptive titles require an opt-in.

Files changed (17)

File	Delta
apps/mobile/src/features/jarvis/JarvisMobileProvider.tsx	+14 −9
apps/mobile/src/features/jarvis/JarvisRouteScreen.tsx	+34 −23
apps/mobile/src/features/jarvis/mobilePushToTalk.ts	+3 −5
apps/mobile/src/features/jarvis/mobileSpeechPolicy.test.ts	+16 −0
apps/mobile/src/features/jarvis/mobileSpeechPolicy.ts	+17 −0
apps/mobile/src/features/jarvis/useJarvisVoice.ts	+11 −2
apps/server/src/jarvis/Layers/JarvisController.test.ts	+66 −0
apps/server/src/jarvis/Layers/JarvisController.ts	+43 −0
apps/server/src/jarvis/Services/JarvisController.ts	+13 −0
apps/server/src/jarvis/push/ExpoPushNotifications.test.ts	+22 −0
apps/server/src/jarvis/push/ExpoPushNotifications.ts	+37 −11
packages/contracts/src/jarvis.ts	+5 −0
packages/jarvis-core/src/command.test.ts	+5 −0
packages/jarvis-core/src/command.ts	+28 −1
packages/jarvis-core/src/groundVoiceTurn.test.ts	+28 −0
packages/jarvis-core/src/groundVoiceTurn.ts	+226 −80
packages/jarvis-core/src/semantic.ts	+31 −1

Issues table (16)

#	File	Lines	Priority	Type	Issue
1	packages/jarvis-core/src/groundVoiceTurn.ts	321–469	P1	logic	Locate a project slot before catalog matching
2	packages/jarvis-core/src/groundVoiceTurn.ts	402–426	P1	logic	Bind confirmation to the selected candidate’s original span
3	packages/jarvis-core/src/groundVoiceTurn.ts	398–413	P1	logic	Validate stale confirmations before returning not-mentioned
4	apps/web/src/components/jarvis/JarvisManagerDialog.tsx	910–947	P1	logic	Do not dispatch web voice matches that still need confirmation
5	packages/jarvis-core/src/groundVoiceTurn.ts	326–383	P1	logic	Bound and index grounding before running it on UI threads
6	apps/mobile/src/features/jarvis/JarvisRouteScreen.tsx	90–111	P1	logic	Keep terminal outcomes and supersede stale blockers
7	apps/mobile/src/features/jarvis/JarvisRouteScreen.tsx	45–54	P1	logic	Stop route-owned speech when Jarvis loses focus
8	apps/mobile/src/features/jarvis/JarvisMobileProvider.tsx	430–461	P1	logic	Do not speculate about project work before validation
9	apps/server/src/jarvis/Layers/JarvisController.ts	442–551	P1	logic	Make conversation genuinely project-independent
10	apps/server/src/jarvis/Layers/JarvisController.ts	68–95, 469–551	P1	logic	Answer conversation in one model call and expose failures honestly
11	apps/server/src/jarvis/Layers/JarvisController.ts	540–551	P2	logic	Apply request idempotency to conversation answers
12	apps/server/src/jarvis/push/ExpoPushNotifications.ts	119–125, 181–195	P1	logic	Keep push notification content private by default
13	apps/server/src/jarvis/push/ExpoPushNotifications.ts	173–196	P1	logic	Classify push events before loading full thread details
14	apps/mobile/src/features/jarvis/mobileSpeechPolicy.ts	34–51	P2	style	Share typed spoken-summary policy across clients
15	packages/jarvis-core/src/groundVoiceTurn.ts	98–161, 342–387	P2	style	Remove the duplicate dead span scanner
16	docs/user/jarvis-mobile.md	1–27	P2	info	Update docs for the changed capability and lifecycle

Request flow

flowchart LR
  U[Voice or text] --> C[Client grounding]
  C -->|project ref + utterance| H[Host grounding and semantic supervisor]
  H -->|control| T[T3 orchestration/provider]
  H -->|converse| A[Second supervisor answer call]
  T --> P[Live presentation + Task Desk]
  P --> S[Mobile/Desktop speech]
  T --> N[Push reactor]
  classDef risk fill:#2a0d12,stroke:#fb7185,color:#fff
  class C,H,A,P,N risk

Prompt for all review comments

Prompt to re-run this review

Validation

✓ Remote branch verified: local HEAD and origin/codex/jarvis-orchestrator both b83823ba.

✓ 87 focused tests across seven touched suites passed.

✓ Focused typechecks passed for contracts, jarvis-core, server, and mobile; server emitted existing Effect suggestions only.

! Direct probes reproduced incidental routing, explicit-target ambiguity, stale confirmation, and wrong-span canonicalization.

! Matcher probe: 29 ms / 40 names, 742 ms / 1,200 names, 1,527 ms / 2,400 names.

No browser, simulator, microphone, notification device, or real speech-model acceptance pass was run.

Review comments

packages/jarvis-core/src/groundVoiceTurn.ts · 321–469Locate a project slot before catalog matchinglogicP1correctness

The new matcher treats every token window as a possible project name. The explicit-only mode now means only exact matching, not explicit project syntax, so typed text such as ‘fix auth’ switches to a project named Auth. Voice input can also auto-route an ordinary task word at the 0.8 spelling threshold.

It also flattens exact hits across the whole sentence. ‘In Web, fix the API response’ becomes ambiguous when Web and API are both projects, even though the user supplied an explicit target. A more dangerous variant is an exact project word in the objective beating a fuzzy but syntactically clear trailing project name.

This is a direct regression in Jarvis’s trust contract. Detect one bounded project-bearing slot first, give explicit syntax precedence, and use phonetic or edit-distance matching only to resolve that slot against real catalog entries.

Restore slot detection as the authority boundary; make explicit-only require explicit syntax; rank explicit slots before inferred trailing slots; never scan arbitrary objective spans for routing.

Prompt for AI agents

packages/jarvis-core/src/groundVoiceTurn.ts · 402–426Bind confirmation to the selected candidate’s original spanlogicP1data-integrity

The confirmed branch finds the selected candidate by ID but canonicalizes `ranked[0]`, the best span across every candidate. The pending frame stores candidate identity but not the matched span that caused the clarification.

The failure is reproducible: confirming Alertify for ‘Compare Jarvis and Alertify’ produces ‘Compare Alertify and Alertify’. A project clarification can therefore alter the work instruction while still routing to the selected project.

Persist the original slot boundaries with the pending clarification, or recompute only the confirmed candidate within the original slot. Route identity and canonical text must come from the same match.

Carry `{ heard, start, end }` in the project clarification frame and canonicalize that exact span after the selected project is revalidated.

Prompt for AI agents

packages/jarvis-core/src/groundVoiceTurn.ts · 398–413Validate stale confirmations before returning not-mentionedlogicP1correctness

The function returns not-mentioned when ranking is empty before it validates `confirmedCandidateId`. If the catalog becomes empty between question and answer, the explicit stale-project branch is unreachable.

The direct probe `Open Zivil` with an empty catalog and a confirmed Rivvl ID returned ready/not-mentioned rather than ‘That project is no longer available.’ The semantic path may then use ambient project context.

Check the confirmed identity first, and fail closed when it is absent. Disconnection and deletion must never erase the clarification target and resume elsewhere.

Move confirmed-candidate lookup and the unavailable result ahead of the ranked-length early return.

Prompt for AI agents

apps/web/src/components/jarvis/JarvisManagerDialog.tsx · 910–947Do not dispatch web voice matches that still need confirmationlogicP1correctness

The shared grounding result correctly distinguishes resolved matches from needs-confirmation. The web dialog ignores that distinction: at lines 916–918 it assigns the proposed project directly and continues submission.

This was risky before, but match-first grounding makes it routine because ordinary phrases now reach the phonetic threshold. The direct probe ‘Review latest changes’ against Rivvl returned needs-confirmation; web would route it to Rivvl instead of asking.

Use the same typed pause flow as mobile. A needs-confirmation result must become a pending choice and cannot populate `groundedVoiceProject` until the user accepts it.

Route needs-confirmation through `voiceClarificationRef` with one candidate and `acceptsAffirmation`; only resolved matches may set the target.

Prompt for AI agents

packages/jarvis-core/src/groundVoiceTurn.ts · 326–383Bound and index grounding before running it on UI threadslogicP1performance

Every voice turn scans every candidate name against every utterance window and allocates edit-distance rows while repeatedly normalizing and recomputing Soundex. One long alias also raises the window limit for every short name, and the `Math.max(...allNames)` spread is itself unbounded.

A local five-run probe measured about 29 ms for 40 names, 742 ms for 1,200 names, and 1,527 ms for 2,400 names on this machine. Web and mobile invoke this synchronously on their JavaScript UI path, and the Host repeats grounding afterward.

Precompile normalized names and phonetic keys when catalogs change, index exact names, cap tokens/names/window width, and fuzzy-score only the extracted project slot and a small shortlist. This also removes the paired-client CPU-exhaustion path.

Introduce a compiled bounded vocabulary and a `ground(slot, compiledCatalog)` API; avoid Levenshtein until exact and phonetic indexes produce a small candidate set.

Prompt for AI agents

apps/mobile/src/features/jarvis/JarvisRouteScreen.tsx · 90–111Keep terminal outcomes and supersede stale blockerslogicP1correctness

Task cards show state, title, and objective. They do not contain the assistant’s terminal result or failure text, so completed and failed presentations are not duplicates. The new fallback shows a terminal presentation only when there is no focused or recent task, a condition the just-completed task normally prevents.

The inverse state is also wrong. Presentation IDs are per activity, so a later completion does not replace an earlier approval or input presentation. The filter hides the completion and leaves the historical blocker marked as live.

Collapse presentations by task/turn and keep the newest event authoritative. Show the latest terminal outcome until the user dismisses it or a newer outcome supersedes it; derive blocker status from current task state.

Project one newest presentation per task/turn, with terminal events superseding blockers; do not use task-card presence as a proxy for rendered result text.

Prompt for AI agents

apps/mobile/src/features/jarvis/JarvisRouteScreen.tsx · 45–54Stop route-owned speech when Jarvis loses focuslogicP1security

The blur cleanup now cancels only capture and deliberately lets playback continue. At the same time it detaches the speech sink and leaves the route where the microphone button provides barge-in.

This contradicts both the user guide and internal ownership document, which say leaving Jarvis cancels playback and active synthesis. A user opening another screen can hear private task text with no visible stop control.

Restore `cancelSurface()` on blur. If background speech is a desired product feature, move ownership to an app-level player with a persistent stop control and an explicit preference before changing lifecycle semantics.

Replace `voice.cancelCapture()` with `voice.cancelSurface()` in focus cleanup, or introduce a global visible player before allowing route-independent playback.

Prompt for AI agents

apps/mobile/src/features/jarvis/JarvisMobileProvider.tsx · 430–461Do not speculate about project work before validationlogicP1correctness

Mobile now says ‘Taking a look at Project’ before the Host knows the semantic action or accepts dispatch. It then discards the schema-bounded acknowledgement produced by the semantic layer for actual provider work.

The message is misleading for general questions and control commands, and it creates a client-specific acknowledgement policy that diverges from web. The comment says the server acknowledgement remains visible, but the UI displays `Started objective` instead.

Keep the immediate latency cue action-neutral, then speak the Host-owned acknowledgement only for an accepted started result. One layer should decide contextual wording and speech eligibility.

Speak a neutral cue before `execute`; after `status: started`, speak `result.value.acknowledgement` through `shouldSpeakMobile`.

Prompt for AI agents

apps/server/src/jarvis/Layers/JarvisController.ts · 442–551Make conversation genuinely project-independentlogicP1maintainability

The new converse command says it needs no project or task, but it remains behind `JarvisControllerExecuteInput.projectId`, mobile’s has-project push-to-talk gate, project selection, and project-bound mesh execute routing.

On a fresh Controller installation or a temporarily disconnected execution catalog, the user cannot ask a general question. That is exactly where a project-independent assistant path would be useful.

Classify before choosing an execution project, or add a discriminated project-free conversation request. Keep coding commands on the current node-qualified path.

Use a request union: `{ kind: 'control', projectRef, ... } | { kind: 'converse', voiceNodeId?, ... }`, with deterministic classification before project authorization.

Prompt for AI agents

apps/server/src/jarvis/Layers/JarvisController.ts · 68–95, 469–551Answer conversation in one model call and expose failures honestlylogicP1performance

A converse request first calls the supervisor to classify the action, then calls the same provider again in a second temporary directory to generate the answer. This doubles the slowest part of the voice path and is likely why the client now tries to mask latency with speculative speech.

The second call converts provider unavailability, schema failure, and execution failure into ‘I couldn’t answer that just now,’ then returns `status: acknowledged`. There is no diagnostic log and no typed unavailable state.

Let the first structured proposal carry a bounded answer when action is converse, or use a deliberate fast classifier before one answer call. Return typed failure and log the cause instead of labelling failure as successful output.

Extend the semantic result with a bounded nullable `answer`, validate it only for converse, and remove `interpreter.converse`; otherwise return a typed unavailable result from the second call.

Prompt for AI agents

apps/server/src/jarvis/Layers/JarvisController.ts · 540–551Apply request idempotency to conversation answerslogicP2data-integrity

The controller computes an acceptance key for the request, but the converse early return emits no orchestration command or receipt and never uses the request metadata retained on the converse command.

If the network drops after generation, a retry with the same request ID executes the model again. That breaks the documented idempotency expectation even though no coding task is created.

Either cache the bounded answer by acceptance key for the request lifetime or explicitly exempt conversation from the idempotent execute contract with a separate endpoint. Do not carry unused identity fields.

Persist or cache one bounded converse result keyed by the authenticated acceptance key, or move converse outside the receipt-backed execute API and document its retry semantics.

Prompt for AI agents

apps/server/src/jarvis/push/ExpoPushNotifications.ts · 119–125, 181–195Keep push notification content private by defaultlogicP1security

Push copy now sends thread and project titles to Expo and renders them in the notification. These fields often contain customer names, incident descriptions, repository names, or security findings.

There is no descriptive-notification preference, redaction policy, or lock-screen warning. The project title is also unbounded before it enters the request body.

Use generic notification text by default. Descriptive previews should require an explicit preference and should be bounded and redacted before third-party transmission.

Default to `Task completed`, `Input needed`, and similar generic copy; add an opt-in before fetching or sending titles.

Prompt for AI agents

apps/server/src/jarvis/push/ExpoPushNotifications.ts · 173–196Classify push events before loading full thread detailslogicP1performance

The subscriber calls `getThreadDetailById` before `pushMessageForEvent` determines whether the activity maps to approval, input, completion, or failure. Tool, progress, checkpoint, and ordinary activity events all pay the enrichment cost.

The detail query loads messages, activities, plans, checkpoints, session, and latest turn. On a sequential event consumer this adds growing database work to a high-volume path and can delay actual push events.

Classify the event first. For the four push-worthy kinds, load only a thread shell/title and project ID, then optionally a project shell if descriptive previews are enabled.

Call `notificationKindForEvent` before entering the enrichment Effect; use a lightweight shell query instead of full detail.

Prompt for AI agents

apps/mobile/src/features/jarvis/mobileSpeechPolicy.ts · 34–51Share typed spoken-summary policy across clientsstyleP2maintainability

Mobile takes two raw sentences and 240 characters, while desktop strips Markdown/code and permits 460 characters. The mobile helper accepts `kind: string`, so a future presentation kind silently falls into the speak-in-full branch.

Shorter completion speech is a real product improvement, but arbitrary first-sentence truncation is not a reliable summary and can omit the actual result. Raw Markdown and code punctuation can also sound bad through TTS.

Move normalization and bounded spoken-summary selection into jarvis-core with a closed presentation-kind type. Better still, let the Host provide an explicit bounded spoken summary beside the full durable result.

Accept a typed presentation event and share Markdown normalization; add an optional Host-generated `spokenSummary` rather than deriving meaning by truncation.

Prompt for AI agents

packages/jarvis-core/src/groundVoiceTurn.ts · 98–161, 342–387Remove the duplicate dead span scannerstyleP2maintainability

`SpanHit` and `scanSpans` are unused. `groundVoiceTurn` contains a second copy of the same loops, but its tie-breaker prefers longer heard text while the dead helper does not.

This is exactly the kind of duplication that causes a routing fix to land in the wrong implementation. `ProjectMention.explicit` is also now populated but never read.

Delete the abandoned implementation as part of the slot-first redesign, or make one scanner the only source of candidate-associated hits and keep ranking decisions separate.

Keep one tested scanner, one ranking function, and one policy function; remove `ProjectMention.explicit` if explicitness is represented by the selected slot type.

Prompt for AI agents

docs/user/jarvis-mobile.md · 1–27Update docs for the changed capability and lifecycleinfoP2maintainability

No Markdown changed across a product behavior range that adds conversation, descriptive push copy, barge-in, new speech truncation, and different route-blur playback behavior.

The existing mobile guide explicitly says leaving Jarvis stops playback and synthesis, which the code no longer does. The controller docs also describe the neutral local cue and Host-owned accepted acknowledgement, not the new mobile behavior.

Fix behavior first, then document the shipped conversation boundary, speech-summary rule, barge-in behavior, notification privacy default, and any intentional lifecycle change.

Update `docs/user/jarvis-mobile.md`, `docs/internals/jarvis-controller.md`, and `docs/internals/jarvis-mobile-voice.md` only after the owning contracts are settled.

Prompt for AI agents

Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate.

Review sidecar: /home/abstergo/Documents/reviews/Jarvis-5baf144b-through-b83823ba-code-review.json

In `packages/jarvis-core/src/groundVoiceTurn.ts` around lines 321–469, replace all-span mention detection with a bounded project-slot-first flow. Preserve explicit-only semantics, prioritize explicit `in X` or `X project` syntax, and apply exact/spelling/phonetic catalog matching only inside the selected slot. Add negative regressions for `fix auth`, `what is the weather today`, and `In Web, fix the API response`, plus the positive ASR corrections already covered.

In `packages/jarvis-core/src/groundVoiceTurn.ts` around lines 402–426 and the project pending-interaction contract, retain the exact project mention span that created clarification. On confirmation, revalidate the selected candidate and replace only that stored span. Add a regression proving that selecting Alertify for `Compare Jarvis and Alertify` never rewrites `Jarvis` or duplicates the selected name.

In `packages/jarvis-core/src/groundVoiceTurn.ts` around lines 398–413, validate `confirmedCandidateId` before any empty-ranking return. Return the existing unavailable clarification if the project vanished, even when the current catalog has no candidates, and add a regression for confirmation after project deletion or node disconnect.

In `apps/web/src/components/jarvis/JarvisManagerDialog.tsx` around lines 910–947, stop converting `needs-confirmation` into a grounded project. Build a one-candidate pending voice clarification, speak the prompt, pause the FIFO item, and resume only after explicit acceptance. Add parity tests with mobile and a negative case where `Review latest changes` must not select Rivvl.

In `packages/jarvis-core/src/groundVoiceTurn.ts` around lines 326–383, replace the candidate × name × token-window nested matcher with a compiled bounded catalog. Normalize names and Soundex once, index exact forms, cap token/name/window sizes, and run edit distance only for a small slot-scoped shortlist. Add a benchmark-style regression with a realistic multi-node catalog and assert the path stays comfortably below one frame or move it off the UI thread.

In `apps/mobile/src/features/jarvis/JarvisRouteScreen.tsx` around lines 90–111 and `JarvisMobileProvider` presentation buffering, derive one current presentation per task or turn. Let completion/failure supersede prior approval/input events and keep the latest terminal text visible even when its task is focused or recent. Add projection tests for approval→completed, input→failed, and ordinary completed-task flows.

In `apps/mobile/src/features/jarvis/JarvisRouteScreen.tsx` around lines 45–54, restore route cleanup that cancels capture, synthesis, queue, and playback via `voice.cancelSurface()`. Keep already submitted coding work running. If product wants background speech, implement it as app-level ownership with a visible stop action and update both user and internal docs.

In `apps/mobile/src/features/jarvis/JarvisMobileProvider.tsx` around lines 430–461, replace the speculative project acknowledgement with a neutral local cue. On an accepted `started` result, consume the validated `result.value.acknowledgement` using the shared mobile speech policy. Add tests for converse, status, stop, clarification, rejection, and provider-work actions so mobile and web cannot drift.

Across `apps/server/src/jarvis/Layers/JarvisController.ts` around lines 442–551, `JarvisControllerExecuteInput`, mesh execution, and mobile push-to-talk gating, separate project-free conversation from project-bound control. Allow a general question without any project while retaining node-qualified authority for every coding or task action. Add fresh-install and disconnected-catalog tests.

In `apps/server/src/jarvis/Layers/JarvisController.ts` around lines 68–95 and 469–551 plus `packages/jarvis-core/src/semantic.ts`, remove the two-round-trip converse path. Prefer one structured supervisor response containing a bounded answer for `action: converse`, while deterministic code still validates the action. Preserve real errors as a typed unavailable result and log the cause. Add tests for provider missing, invalid schema, generation failure, and successful one-call conversation.

In `apps/server/src/jarvis/Layers/JarvisController.ts` around lines 540–551 and the converse command contract, make retry behavior explicit. Reuse one answer for the same authenticated acceptance key, or move conversation to a separate non-idempotent request type and remove unused `requestMetadata`. Add a lost-response retry test.

In `apps/server/src/jarvis/push/ExpoPushNotifications.ts` around lines 119–125 and 181–195, stop including thread/project titles in Expo payloads by default. Add a descriptive-preview preference if desired, enforce length/redaction rules, and test generic default payloads plus opt-in behavior.

In `apps/server/src/jarvis/push/ExpoPushNotifications.ts` around lines 173–196, classify `thread.activity-appended` before any projection read and return immediately for non-push activities. For relevant events, use a lightweight thread shell/title lookup rather than `getThreadDetailById`, and fetch project copy only when the privacy preference requires it. Add a test proving irrelevant activities perform zero projection reads.

In `apps/mobile/src/features/jarvis/mobileSpeechPolicy.ts` around lines 34–51 and the desktop reporter logic, consolidate spoken-result normalization in `jarvis-core` using the closed presentation kind type. Strip Markdown/code consistently and prefer an explicit bounded spoken summary from the Host over the first two raw sentences. Preserve the full result in durable task UI.

In `packages/jarvis-core/src/groundVoiceTurn.ts` around lines 98–161 and 342–387, remove the unused `scanSpans`/`SpanHit` copy and the unread `ProjectMention.explicit` state. After the routing fix, keep span enumeration, candidate ranking, and decision thresholds in separate small functions with direct tests.

After resolving the implementation findings, update `docs/user/jarvis-mobile.md`, `docs/internals/jarvis-controller.md`, and `docs/internals/jarvis-mobile-voice.md` to match shipped behavior. Cover project-free conversation, accepted acknowledgement ownership, barge-in, spoken summaries, push-preview privacy, and route-blur cancellation. Do not document the current contradictions as intended behavior unless the product decision is explicit.

/abbyview 5baf144b-through-b83823ba
Review round 2. Read /home/abstergo/Documents/reviews/Jarvis-5baf144b-through-b83823ba-code-review.json and /home/abstergo/Documents/reviews/Jarvis-5baf144b-through-b83823ba-code-review.html. This is incremental: preserve the frozen walkthrough and prior comment bodies, append only new findings, and update statuses/confidence.

Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate.

In `packages/jarvis-core/src/groundVoiceTurn.ts` around lines 321–469, replace all-span mention detection with a bounded project-slot-first flow. Preserve explicit-only semantics, prioritize explicit `in X` or `X project` syntax, and apply exact/spelling/phonetic catalog matching only inside the selected slot. Add negative regressions for `fix auth`, `what is the weather today`, and `In Web, fix the API response`, plus the positive ASR corrections already covered.

Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate.

In `packages/jarvis-core/src/groundVoiceTurn.ts` around lines 402–426 and the project pending-interaction contract, retain the exact project mention span that created clarification. On confirmation, revalidate the selected candidate and replace only that stored span. Add a regression proving that selecting Alertify for `Compare Jarvis and Alertify` never rewrites `Jarvis` or duplicates the selected name.

Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate.

In `packages/jarvis-core/src/groundVoiceTurn.ts` around lines 398–413, validate `confirmedCandidateId` before any empty-ranking return. Return the existing unavailable clarification if the project vanished, even when the current catalog has no candidates, and add a regression for confirmation after project deletion or node disconnect.

Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate.

In `apps/web/src/components/jarvis/JarvisManagerDialog.tsx` around lines 910–947, stop converting `needs-confirmation` into a grounded project. Build a one-candidate pending voice clarification, speak the prompt, pause the FIFO item, and resume only after explicit acceptance. Add parity tests with mobile and a negative case where `Review latest changes` must not select Rivvl.

Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate.

In `packages/jarvis-core/src/groundVoiceTurn.ts` around lines 326–383, replace the candidate × name × token-window nested matcher with a compiled bounded catalog. Normalize names and Soundex once, index exact forms, cap token/name/window sizes, and run edit distance only for a small slot-scoped shortlist. Add a benchmark-style regression with a realistic multi-node catalog and assert the path stays comfortably below one frame or move it off the UI thread.

Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate.

In `apps/mobile/src/features/jarvis/JarvisRouteScreen.tsx` around lines 90–111 and `JarvisMobileProvider` presentation buffering, derive one current presentation per task or turn. Let completion/failure supersede prior approval/input events and keep the latest terminal text visible even when its task is focused or recent. Add projection tests for approval→completed, input→failed, and ordinary completed-task flows.

Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate.

In `apps/mobile/src/features/jarvis/JarvisRouteScreen.tsx` around lines 45–54, restore route cleanup that cancels capture, synthesis, queue, and playback via `voice.cancelSurface()`. Keep already submitted coding work running. If product wants background speech, implement it as app-level ownership with a visible stop action and update both user and internal docs.

Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate.

In `apps/mobile/src/features/jarvis/JarvisMobileProvider.tsx` around lines 430–461, replace the speculative project acknowledgement with a neutral local cue. On an accepted `started` result, consume the validated `result.value.acknowledgement` using the shared mobile speech policy. Add tests for converse, status, stop, clarification, rejection, and provider-work actions so mobile and web cannot drift.

Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate.

Across `apps/server/src/jarvis/Layers/JarvisController.ts` around lines 442–551, `JarvisControllerExecuteInput`, mesh execution, and mobile push-to-talk gating, separate project-free conversation from project-bound control. Allow a general question without any project while retaining node-qualified authority for every coding or task action. Add fresh-install and disconnected-catalog tests.

Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate.

In `apps/server/src/jarvis/Layers/JarvisController.ts` around lines 68–95 and 469–551 plus `packages/jarvis-core/src/semantic.ts`, remove the two-round-trip converse path. Prefer one structured supervisor response containing a bounded answer for `action: converse`, while deterministic code still validates the action. Preserve real errors as a typed unavailable result and log the cause. Add tests for provider missing, invalid schema, generation failure, and successful one-call conversation.

Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate.

In `apps/server/src/jarvis/Layers/JarvisController.ts` around lines 540–551 and the converse command contract, make retry behavior explicit. Reuse one answer for the same authenticated acceptance key, or move conversation to a separate non-idempotent request type and remove unused `requestMetadata`. Add a lost-response retry test.

Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate.

In `apps/server/src/jarvis/push/ExpoPushNotifications.ts` around lines 119–125 and 181–195, stop including thread/project titles in Expo payloads by default. Add a descriptive-preview preference if desired, enforce length/redaction rules, and test generic default payloads plus opt-in behavior.

Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate.

In `apps/server/src/jarvis/push/ExpoPushNotifications.ts` around lines 173–196, classify `thread.activity-appended` before any projection read and return immediately for non-push activities. For relevant events, use a lightweight thread shell/title lookup rather than `getThreadDetailById`, and fetch project copy only when the privacy preference requires it. Add a test proving irrelevant activities perform zero projection reads.

Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate.

In `apps/mobile/src/features/jarvis/mobileSpeechPolicy.ts` around lines 34–51 and the desktop reporter logic, consolidate spoken-result normalization in `jarvis-core` using the closed presentation kind type. Strip Markdown/code consistently and prefer an explicit bounded spoken summary from the Host over the first two raw sentences. Preserve the full result in durable task UI.

Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate.

In `packages/jarvis-core/src/groundVoiceTurn.ts` around lines 98–161 and 342–387, remove the unused `scanSpans`/`SpanHit` copy and the unread `ProjectMention.explicit` state. After the routing fix, keep span enumeration, candidate ranking, and decision thresholds in separate small functions with direct tests.

Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate.

After resolving the implementation findings, update `docs/user/jarvis-mobile.md`, `docs/internals/jarvis-controller.md`, and `docs/internals/jarvis-mobile-voice.md` to match shipped behavior. Cover project-free conversation, accepted acknowledgement ownership, barge-in, spoken summaries, push-preview privacy, and route-blur cancellation. Do not document the current contradictions as intended behavior unless the product decision is explicit.